worker: give names to MessagePort functions
#58307
Merged
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58307 +/- ##
==========================================
+ Coverage 90.19% 90.21% +0.02%
==========================================
Files 631 633 +2
Lines 186670 186837 +167
Branches 36670 36680 +10
==========================================
+ Hits 168374 168563 +189
+ Misses 11112 11075 -37
- Partials 7184 7199 +15
🚀 New features to boost your workflow:
|
legendecas
approved these changes
May 13, 2025
LiviaMedeiros
added
the
author ready
dario-piotrowicz
approved these changes
May 13, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
LiviaMedeiros
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in b0cf2e2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes names for:
worker_threads.MessagePort.prototype.hasRef(was: anonymous)worker_threads.MessagePort.prototype.close(was: anonymous)worker_threads.MessagePort.prototype.[kCreateEvent](was:value)